RIOT
RIOT copied to clipboard
RIOT-OS
makefiles/tools/serial.inc.mk: make use of pyterm session names
Contribution description
pyterm loggs all terminal output but the feature is very under-utilized.
Especially when multiple terminals are opened, this is very unreliable as all output goes to the default log file, so it is rather random which output gets logged.
Instead, create a session name based on the current time, the application and the board. This helps recovering output later on.
Testing procedure
Run make term as usual, but now you will find multiple log files in ~/.pyterm:
/home/benpicco/.pyterm/T430s:
2023-11-29_20.13.51-gnrc_networking-same54-xpro.log
2023-11-29_20.17.53-hello-world-saml21-xpro.log
Issues/PRs references
Murdock results
:heavy_check_mark: PASSED
59bb957c840c68a9896bf7b5ea9e0373fcf15945 makefiles/tools/serial.inc.mk: pyterm: log to /tmp by default
| Success | Failures | Total | Runtime |
|---|---|---|---|
| 1 | 0 | 1 | 01m:12s |
Artifacts
Wait a second before merging: I think I encoded the timestamp in the pyterm logfile name in a previous version but got annoyed of logfiles piling up. I any case I wonder whether this setting should be make in the build system or rather in pyterm itself.
Edit: At least the timestamp configuration. If we want to have board and application in there, it has to come from the environment.
Well the logfiles are piling up either way, with this they are at least somewhat useful.
I guess the question is whether one consider a one huge log file or an insane number of log files as more disturbing. How about creating subdirectories per board and creating/updating a tarball upon start for old log files?
The huge file is worse for sure because it's almost impossible to find anything in it.
How about moving the log files to /tmp/pyterm-logs by default. That way, if someone is interested in them, they can be saved. If not, they are removed with the next boot.
The huge file is worse for sure because it's almost impossible to find anything in it.
Why do you think that is easier to find anything in a plethora of files?
How about moving the log files to
/tmp/pyterm-logsby default. That way, if someone is interested in them, they can be saved. If not, they are removed with the next boot.
In that case I would rather vote for disabling logging by default at all.
In the end, it's a matter of personal preferences. Pyterm used to have a config file, but I just realized that the functionality is broken in newer python versions. But I think having a personal config file would be probably the best way to cater all different needs.
Why do you think that is easier to find anything in a plethora of files?
Because now it's basically random which session gets written if you have multiple instances of pyterm open. This makes the automatic logging rather useless (you can still find some information in there, but you can't rely on it).
I would rather vote for disabling logging by default at all.
I'm also fine with that, I guess 99% of the users don't even know that the logging exists and we are just silently wasting disk space there.
How about saving the logs to /tmp by default.
That way, if they are interesting they can easily be moved to a persistent location while not cluttering up the file system in the common case. (This is also a good way to handle the Downloads folder)
Well, my originally thinking was that enabling logging per default to a non-volatile location may be helpful in many cases where you only realize that you would have needed the log afterwards - potentially weeks later.
But probably the most reasonable option would be to re-enable the config file again, disable logging per default, provide documentation, and leave everything up to the user.
my originally thinking was that enabling logging per default to a non-volatile location may be helpful in many cases where you only realize that you would have needed the log afterwards - potentially weeks later.
But in that case individual log files per session would make more sense, otherwise you just have one gargantuan file that might contain the log you need if you are lucky.
That's true. I don't know if the behavior of Python's logging module has changed over the years or if I just thought about the use case of having to concurrent pyterms.
So how should we proceed?
with native now also using pyterm the default-run.log just keeps piling up faster.
I think this is still useful. I'll do a follow-up to make logging off by default, but when it's enabled we should have separate files per session.