RIOT
RIOT copied to clipboard
periph/spi: add support for printing and testing SPI clock rate (2nd)
Contribution description
Taken over from another PR. We will see how much it needs.
Testing procedure
TBD
Issues/PRs references
Based off #16727 from @hugueslarrive
I am just running a build test. Reschedule if needed.
@MrKevinWeiss Since we are now using the ESP-IDF SPI HAL/LL for ESP32, ESP32 has its own periph/spi
implementation which should be covered by this PR. Even though cpu/esp32/periph/spi.c
already uses directly the given clock in spi_acquire
, functions spi_get_clk
and spi_get_freq
have to be implemented and type spi_clk_t
should be removed from here https://github.com/RIOT-OS/RIOT/blob/7ee1b585737b87c5a7df355f81ff113515289dfe/cpu/esp32/include/periph_cpu.h#L576-L583
Yup, looks like it needs more than a simple rebase
@MrKevinWeiss I committed the changes for ESP32 to your branch.
rebased... I will work on porting some robot tests so we can check it on the hardware. Probably worth some manual testing as well.
PASS | FAIL | SKIP |
---|---|---|
1 | 25 | 2 |
✅ slstk3401a
PASS | FAIL | SKIP |
---|---|---|
1 | 0 | 0 |
TEST | RESULT |
---|---|
tests/periph_spi | ✅ pass |
oh ya, going to need a bit more love.
Is this in a reviewable state already? Could you fix the merge conflicts and squash fixup and other "noch mal" style commits, or is there more work needed on the conceptual side anyway?