RIOT icon indicating copy to clipboard operation
RIOT copied to clipboard

drivers/mcp2515: extended can filters not applied

Open firas-hamdi opened this issue 3 years ago • 2 comments

Contribution description

When using the extended CAN frames, I noticed that the filters were not correctly applied and they were considered as standard CAN filters. The reason for this bug is that after the check for filter type (extended or standard), the extended filter's flag is reset and any other later check will consider the filter as standard.

Testing procedure

Apply an extended CAN filter (29 bits) on one mailbox. It will be possible to receive CAN frames on that mailbox only if they have an extended CAN ID matching the filter

firas-hamdi avatar Jul 05 '22 20:07 firas-hamdi

This needs a rebase now

benpicco avatar Jul 13 '22 13:07 benpicco

Should static analysis errors be fixed before merging? Not sure what the habits in RIOT are?

There's three in tests/candev/main.c

wosym avatar Jul 26 '22 21:07 wosym