RIOT icon indicating copy to clipboard operation
RIOT copied to clipboard

gnrc_netif: move msg_queue to gnrc_netif struct

Open benpicco opened this issue 3 years ago • 3 comments

Contribution description

Move the netif thread message queue to the gnrc_netif struct so we don't have to allocate it on the stack (and enlarge the stack when we use a larger queue).

Testing procedure

Most drivers will now have more free stack space, cc110x and nrf24l01p_ng should stay roughly the same as they would handle this manually previously.

Issues/PRs references

alternative to #17905

benpicco avatar Jun 06 '22 09:06 benpicco

I think I'd rather shrink the netif thread stack sizes than blacklisting more boards because the memory for the queue now moved from the stack to a static allocation.

benpicco avatar Jun 07 '22 15:06 benpicco

I think I'd rather shrink the netif thread stack sizes than blacklisting more boards because the memory for the queue now moved from the stack to a static allocation.

Then please go ahead.

miri64 avatar Jun 20 '22 15:06 miri64

Code change looks good to me, but Murdock is not yet happy

maribu avatar Jul 19 '22 04:07 maribu

#17905 now does the same, but with a handy define for the default netif stack size

benpicco avatar Oct 13 '22 15:10 benpicco