RIOT icon indicating copy to clipboard operation
RIOT copied to clipboard

Published 20 hours ago • verified publisher icon RIOT-OS

net/nanocoap: remove coap_pkt token ptr

Open kfessel opened this issue 2 years ago • 5 comments

this might need a deprecation period first

Contribution description

remove the token ptr from nanocoap coap_pkt_t in favour of coap_get_token() introduced in #17976

Testing procedure

murdock build

Issues/PRs references

#17976

wait for #17950

kfessel avatar Apr 22 '22 10:04 kfessel

With #17950 there shouldn't be any actual users of the pointer left - only setters, which can be removed easily.

benpicco avatar Apr 22 '22 10:04 benpicco

lets ping @kaspar030 @miri64 @chrysn if anyone suggests to have a deprecation period for <coap_pkt_t>.token

kfessel avatar Apr 22 '22 10:04 kfessel

some of the changes in 16001848c3b1c0e5ac0dd9fa90603d0fb8c843fb are part of #17950

kfessel avatar Apr 22 '22 12:04 kfessel

Personally I won't insist on having a deprecation period -- especially in this case because using the old access will reliably fail. Adding @cgundogan to the pingees because I suspect he might have PRs around that might be using the token a bit more.

chrysn avatar Apr 25 '22 07:04 chrysn

This needs a rebase, but we can merge this ~~now~~ soon.

benpicco avatar Sep 20 '22 15:09 benpicco

Murdock results

:heavy_check_mark: PASSED

b575f0cdf8bd0fdaa8bcb99ac8d61f6bd0d10730 net/nanocoap: remove coap_pkt token ptr

Success Failures Total Runtime
1983 0 1983 07m:00s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

riot-ci avatar Oct 05 '22 22:10 riot-ci