RIOT icon indicating copy to clipboard operation
RIOT copied to clipboard

examples/gcoap_dtls: Increase stack size

Open maribu opened this issue 2 years ago • 3 comments

Contribution description

As the title says. The stack size was copied over from tests/pkg_tinydtls_sock_async cargo-cult style. Also some typos in the README were fixed.

Testing procedure

Previously on my Nucleo-F767ZI, the CoAP client triggered the MPU stack guard on sending the DTLS hello. With this, the board no longer crashes.

Issues/PRs references

None

maribu avatar Mar 02 '22 14:03 maribu

looks like Makefile.ci now needs an update

benpicco avatar Mar 05 '22 16:03 benpicco

I suppose this is still needed, right?

benpicco avatar Jul 24 '22 20:07 benpicco

It is also needed with LWIP=1 actually. I wonder if stack usage of the client can be reduced a bit instead. Overflowing a 1.5 KiB stack is a bit surprising.

maribu avatar Jul 25 '22 06:07 maribu

I'm cleaning up my stale branches currently. I think this is actually still needed. Any change to get this in? (Once someone fixes the surprising amount of stack consumption, this is a change that is trivial to revert.)

maribu avatar Jan 21 '23 21:01 maribu

bors merge

maribu avatar Jan 22 '23 09:01 maribu

bors cancel bors merge

maribu avatar Jan 22 '23 09:01 maribu

Canceled.

bors[bot] avatar Jan 22 '23 09:01 bors[bot]

bors cancel bors merge

let's see if we can get three PRs into the merge train.

maribu avatar Jan 22 '23 09:01 maribu

Canceled.

bors[bot] avatar Jan 22 '23 09:01 bors[bot]

bors cancel bors merge

maribu avatar Jan 22 '23 09:01 maribu

Canceled.

bors[bot] avatar Jan 22 '23 09:01 bors[bot]

Build failed (retrying...):

bors[bot] avatar Jan 22 '23 09:01 bors[bot]

Build failed:

bors[bot] avatar Jan 22 '23 10:01 bors[bot]

rebased and ran the tool to update the Makefile.ci

bors retry

maribu avatar Jan 22 '23 13:01 maribu

:clock1: Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors[bot] avatar Jan 22 '23 13:01 bors[bot]

Murdock results

:heavy_check_mark: PASSED

965b555d7e098417155fbba8ab0c524028d5b15b examples/gcoap_dtls: Increase stack size

Success Failures Total Runtime
13 0 13 01m:02s

Artifacts

riot-ci avatar Jan 22 '23 13:01 riot-ci

Build succeeded:

bors[bot] avatar Jan 22 '23 16:01 bors[bot]

Thx

maribu avatar Jan 22 '23 17:01 maribu