RIOT
RIOT copied to clipboard
RIOT-OS
sys/net/gnrc: Remove code duplication
Contribution description
While using simian (a tool that can detect code duplication) on RIOT-OS, I found two snippets of code that were good candidates for being factorized. This pull request does not change the behavior of gnrc.
Testing procedure
I compiled for the SAMD21-XPRO board the following examples: gnrc_minimal, gnrc_networking and gnrc_networking_mac.
Issues/PRs references
None.
I compiled for the SAMD21-XPRO board the following examples:
gnrc_minimal,gnrc_networkingandgnrc_networking_mac.
Since I don't have the time to test it myself at the moment, to all testers: Only gnrc_networking_mac uses the modules that are changed here and gnrc_lwmac is only used when explicitly selected in the Makefile.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.
I think it makes sense!
I mean in the scope of DSME coming in and the MAC layers fixed here potentially going out soon ;-)
The question still stands if those mac layers are still needed. We have DSME now, and lwmac and gomach are effectively unmaintained for years. I'd say: Let's rebase this one and merge, then deprecate lwmac and gomach.
