RIOT
RIOT copied to clipboard
RIOT-OS
Add color depth types to disp_dev API
Contribution description
This PR addresses the issue with colors in the disp_dev API. Mentioned briefly in #13787 It's a proposal how to address it. The idea behind this is simple: The user application shouldn't care too much about the underlying color depth of a display. It should provide the color data in the correct format. The driver should do the rest. This also makes it possible to switch displays with different color depths without changing the color data itself. Also the application code should be the same. The user only has to change the makefile. For example:
- User applications uses 24bit color data and a 24bit color display. The driver itself doesn't need to change the data that much, since it can display it directly.
- For another version of the hardware, the user changes the display to a 16bit display. The driver abstracts this, accepts the 24bit color data and transforms it to the needed 16bit color.
This is an down scaling example. The same can be done for up scaling as well. The biggest benefit is backwards compatibility. The user can simply maintain backwards compatibility, without caring too much about the old hardware.
Testing procedure
The tests are not changed yet.
Issues/PRs references
Addresses #13787 . Should be merged after #14051 .
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.
Hi! Do you still plan to get this merged? The PR this depends on got closed by stale bot #14051.
Hi! Do you still plan to get this merged? The PR this depends on got closed by stale bot #14051.
Not really, sorry. There was so much discussion about this (see https://github.com/RIOT-OS/RIOT/issues/13787 etc.) I guess it needs someone to push it. Get all people together, make a clean PR with all the concerns, get it merged.