rgb-std icon indicating copy to clipboard operation
rgb-std copied to clipboard

feat(invoice): add new invoice creation function and dependencies

Open astral-bitlight opened this issue 9 months ago • 3 comments

astral-bitlight avatar Apr 15 '25 05:04 astral-bitlight

Since RgbInvoice is currently a type alias for CallRequest, we can’t directly implement methods like new() on it. To address this, I propose refactoring it into a newtype wrapper (a zero-cost abstraction) with an explicit constructor

astral-bitlight avatar Apr 18 '25 05:04 astral-bitlight

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 4.1%. Comparing base (79e68c1) to head (acb8248). Report is 151 commits behind head on v0.12.

Files with missing lines Patch % Lines
invoice/src/lib.rs 0.0% 28 Missing :warning:
Additional details and impacted files
@@          Coverage Diff           @@
##           v0.12   #305     +/-   ##
======================================
- Coverage    4.9%   4.1%   -0.7%     
======================================
  Files         11     13      +2     
  Lines       1298   1553    +255     
======================================
+ Hits          63     64      +1     
- Misses      1235   1489    +254     
Flag Coverage Δ
rust 4.1% <0.0%> (-0.7%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 19 '25 14:04 codecov[bot]

I've added serde support and fixed constructor param issue

astral-bitlight avatar Apr 21 '25 14:04 astral-bitlight

@astral-bitlight is this PR is still actual and needed?

dr-orlovsky avatar May 23 '25 13:05 dr-orlovsky

We can closed it for now

astral-bitlight avatar May 26 '25 03:05 astral-bitlight