RFRIEDM-Trimble

Results 47 comments of RFRIEDM-Trimble

Considering the upstream PR has seen no activity, thoughts on proceeding with this approach? I'd like to get one merged so we can start tracking `feature-2.0` instead of my fork....

> Considering the upstream PR has seen no activity, thoughts on proceeding with this approach? I'd like to get one merged so we can start tracking `feature-2.0` instead of my...

> Sorry for not responding earlier. I started noticing that rebasing the base branch was repeatedly breaking PRs like this so I started merging instead. What I'd recommend is just...

> Hi, sorry for the late reply again - I think your branch is still off of a stale version of the feature-2.0 branch (Again, this is my fault for...

> That has been pushed as 2.0.0alpha9 (This should probably move out of 'alpha' now...) Just tested it out, it appears to work to handle out of order messages, however...

> Member I edited the json output to remove proprietary info, but the actual log message is the same. I'll take the action to create minimum reproducible bug in the...

Seems the failures in the test report are related to two things: 1) Using f-strings in logger calls is not optimal performance-wise; will switch those. 2) Accessing the protected _client_id...

Ok, got it. Given that, is that actually what's causing the errors? I'm not super familiar with pylint. ``` Your code has been rated at 9.97/10 ERROR: InvocationError for command...

If there is nothing my code caused in terms of tests, can this be merged?

> To fix the lint errors, you need to change all the instances of > > ``` > # pylint: disable=unused-argument > ``` > > to > > ``` >...