RESTED icon indicating copy to clipboard operation
RESTED copied to clipboard

Cannot add request to collection

Open Jiehong opened this issue 7 years ago • 17 comments

Hi,

With Rested 2.0.3 on Firefox 54.0, when trying to add a request to a collection, nothing happens. No error seems to be displayed in the js console (with F12).

I can add a new collection, rename it, but then, adding something to it is impossible.

Jiehong avatar Jun 23 '17 12:06 Jiehong

Can't reproduce this. Can you give me steps to reproduce? I am doing the following:

  1. Click + above collections to create a new collection
  2. Send a request to http://news.ycombinator.com/
  3. Click + above request to add to collection
  4. Request is in collection

eliihen avatar Jun 24 '17 19:06 eliihen

I just tried your procedure in FF 54 on Archlinux, and it works.

My original bug reports was tried on Ubuntu, so I'll give it another try on Monday.

Jiehong avatar Jun 25 '17 09:06 Jiehong

Hi,

I've just retried, and it does work for http://news.ycombinator.com/, but it still doesn't work for the domain I'm targeting.

Unfortunately, the services I'm targeting aren't available outside, so I cannot give a test URL.

So far, the only difference, seems to be that the services uses http/1.1 instead of 2.0, but I haven't been able to reproduce with a public URL yet.

I've saved my trial as a HAR file containing a get on news.ycombinator.com that can be saved into the collection just fine, and a POST on my internal service that cannot be saved in the collection (I've changed the url and the IP).

Note, I've changed the .har to .txt, but it's exactly the same.

Archive 17-06-26 09-22-50.txt

Can you use this data to reproduce, or is there a way for me to provide you with a way to reproduce if this doesn't help?

Jiehong avatar Jun 26 '17 07:06 Jiehong

I had the exact same issue in the same context.

My URL was https://api.godaddy.com/v1/domains, with an Authorization header. Call worked fine, but all attempts (same as Jiehong's) to add it to collection silently failed.

I then tried http://news.ycombinator.com/, which worked. Then I tried my URL again and was able to add it.

osoviejo avatar Jun 29 '17 07:06 osoviejo

I hear you guys - I'll do some more work on RESTED this week, and this is one of the things I'll look into

eliihen avatar Jun 29 '17 07:06 eliihen

I looked into this, but did not get any wiser. I am going to add some more logging to this release so we may be able to debug this together. Once you get the next version, which should be 2.0.4, please post whatever is in your console here after trying to add the request to a collection.

eliihen avatar Jul 01 '17 15:07 eliihen

Great.

Side question: @esphen : is there a way to know when this extension version will be ready? I'm guessing that there is some queuing for having it signed on FF side, but I am unable to find a page that shows such a queue, or pending versions in general.

Jiehong avatar Jul 03 '17 09:07 Jiehong

@Jiehong Not for you, I'm afraid. As the author of the extension, I can see the position in the review queue, but this is not public. You'll just need to look at about:addons once in a while.

Mozilla usually take between a few days to a week to review.

eliihen avatar Jul 03 '17 10:07 eliihen

Hi, I think I found where the bug is. It doesn't add the request into the collection if you take it from the history and do not make any modification in URL. Once you change something or make a brand new URL it added as it should

Anyway thank you for a such great tool

dr-dobermann avatar Sep 17 '17 03:09 dr-dobermann

Thanks for the info @dr-dobermann, that seems to be the case. I'll look into that!

eliihen avatar Sep 18 '17 06:09 eliihen

In case there's still any question, I - too - am having this problem, and this is what the console says:

Not adding request because formPristine=true || formInvalid=false

That message is followed by a logged object: log

rockerest avatar Nov 02 '17 17:11 rockerest

Thanks for that @rockerest. It seems it is as suspected - the form is not marked as being in a dirty state and then trips up on the validation.

eliihen avatar Nov 03 '17 06:11 eliihen

Bug seems not to be fixed (August 2018)

schreibd avatar Sep 06 '18 07:09 schreibd

Can confirm this doesn't work for local domains

checor avatar Oct 05 '18 17:10 checor

Still not resolved

chakrihacker avatar May 24 '19 05:05 chakrihacker

I had the exact same issue, working on a local domain

Session

Rested 2.3.1 Firefox 69.0.2 / Linux

riri avatar Oct 13 '19 09:10 riri

still ... changed localhost to 127.0.0.1 as bypass and it gets smooth !

pfouque06 avatar Jul 08 '20 17:07 pfouque06