deployer icon indicating copy to clipboard operation
deployer copied to clipboard

[Feature] Laravel Dusk tests

Open bbashy opened this issue 7 years ago • 8 comments

Would you be willing to add Laravel Dusk tests to this project?

I've written a good number of tests on some projects and I know you love testing so hopefully I can get the ball rolling (pun intended).

bbashy avatar Mar 26 '17 12:03 bbashy

Absolutely, you'll notice the Browser folder exists in tests/, I just didn't want to look at it until I start on rewriting the horrendous javascript 😂

REBELinBLUE avatar Mar 26 '17 12:03 REBELinBLUE

That's a good point. Were you going to redo some front-end elements as well?

I can start writing some basic ones just for forms if you wanted? Maybe some folder structure ideas.

bbashy avatar Mar 26 '17 12:03 bbashy

I hadn't planned to change the UI in any way

REBELinBLUE avatar Mar 26 '17 14:03 REBELinBLUE

JavaScript shouldn't modify the elements a lot then?

bbashy avatar Mar 27 '17 12:03 bbashy

Fair point, it shouldn't

REBELinBLUE avatar Mar 27 '17 20:03 REBELinBLUE

Isn't this more for phptesting.org ?

cerw avatar May 17 '17 02:05 cerw

@cerw You're thinking about it the other way around I think? This issue is for adding actual dusk tests to deployer repo, not deployment.

bbashy avatar May 17 '17 13:05 bbashy

@bbashy sorry my bad. I just implemented my dusk tests on https://github.com/block8/phpci , its tricky one, be great to know how guys implementing it on CI

cerw avatar May 17 '17 13:05 cerw