ARSCLib icon indicating copy to clipboard operation
ARSCLib copied to clipboard

Refactor/optimize binary operations

Open Tahgolov opened this issue 4 months ago • 5 comments

@REAndroid Im checking your code related with binary operations after https://github.com/REAndroid/ARSCLib/pull/89. I think I can present small imrovements. Please give me a feedback if this is useful for your project.

Tahgolov avatar Aug 14 '25 20:08 Tahgolov

Looks very nice, allow me some time to check.

Of course your contribution is beyond useful, thank you very much !

REAndroid avatar Aug 14 '25 21:08 REAndroid

@REAndroid for possible issues from my side I'll write some unit tests for places where it's needed

Tahgolov avatar Aug 15 '25 15:08 Tahgolov

@REAndroid I found an issue and fixed it, and I also wrote some unit tests for you to check.

Tahgolov avatar Aug 16 '25 09:08 Tahgolov

@Tahgolov It would be easier for me if you do unit tests on separate PR, check this commit:https://github.com/REAndroid/ARSCLib/commit/217e005aaf4299e2cd3b418700a7181ba4b4acb7

REAndroid avatar Aug 16 '25 19:08 REAndroid

#91

Tahgolov avatar Aug 17 '25 18:08 Tahgolov