SS3D icon indicating copy to clipboard operation
SS3D copied to clipboard

Improve Chat Tab Buttons

Open cosmiccoincidence opened this issue 3 years ago • 4 comments

Goal

  • [X] 1. The buttons to control the chat tabs could use an upgrade. Switching tabs works fine and so does making a new tab, but the close button seems to be broken. This button should close the active tab, if the active tab is the only tab in the window then it closes the whole window.

  • [X] 2. Move the new tab button to the left side of the chat (see my shitty image below).

  • [ ] 3. Add a new minimize button where the new tab button was located (see my shitty image below). This button should toggle the whole chat window close while preserving all the tabs. Reopening the chat window is done by clicking the chat button at the bottom of the screen still.

Media

Unity_7oi7LojhQq

cosmiccoincidence avatar Jul 22 '21 19:07 cosmiccoincidence

  1. I'll get that button working!
  2. We had the same idea here haha. When I was solving #753 I did exactly this without even seeing this issue first.
  3. This goes outside of the scope of what my PR is trying to do (being chat fixes, not new features) but I could include this if you would like!

singulocity avatar Aug 10 '21 16:08 singulocity

Okay, the first two are completed. Let me know if you want the upcoming PR to have 3.

singulocity avatar Aug 10 '21 17:08 singulocity

Okay, the first two are completed. Let me know if you want the upcoming PR to have 3.

I'll let you decide if you want to tackle 3 in the same one or not. If not, I'll cross out 1 & 2 and keep the issue open for 3.

cosmiccoincidence avatar Aug 10 '21 17:08 cosmiccoincidence

Okay, the first two are completed. Let me know if you want the upcoming PR to have 3.

I'll let you decide if you want to tackle 3 in the same one or not. If not, I'll cross out 1 & 2 and keep the issue open for 3.

Okay, I could do it as a separate PR later then! Someone else could try it before I get to it then.

singulocity avatar Aug 10 '21 17:08 singulocity