SS3D icon indicating copy to clipboard operation
SS3D copied to clipboard

Published 20 hours ago • verified publisher icon RE-SS3D

Rename all "System" to "SubSystem"

Open stilnat opened this issue 1 year ago • 4 comments

Summary

Rename all "System" to "SubSystem". So PlayerSystem, should become PlayerSubSystem. That would include :

  • System.cs
  • GameModeSystem.cs
  • RoundSystem.cs
  • RoundSystemBase.cs
  • MindSystem.cs
  • NetworkSystem.cs
  • PermissionSystem.cs
  • PlayerSystem.cs
  • ReadyPlayerSystem.cs
  • SubstanceSystem.cs
  • SystemLocator.cs

stilnat avatar Feb 12 '23 11:02 stilnat

The contributor or reviewer should be prepared to update the documentation on this when the PR is ready for merge.

https://ss3d.gitbook.io/programming/guidelines/code-design/system

cosmiccoincidence avatar Mar 15 '23 06:03 cosmiccoincidence

The new naming definition is Subsystem, NOT Manager.

joaoburatto avatar Mar 20 '23 17:03 joaoburatto

closed because not good renaming

stilnat avatar Mar 20 '23 22:03 stilnat

Classes still have the System postfix and need to be updated to SubSystem according to John.

cosmiccoincidence avatar Mar 20 '23 22:03 cosmiccoincidence