generator icon indicating copy to clipboard operation
generator copied to clipboard

Generate makefile misses prepare steps

Open LeroyR opened this issue 3 months ago • 4 comments

prepare-hook/unix is not included in the generated makefile.

LeroyR avatar Oct 01 '25 08:10 LeroyR

The version in branch makefile-hooks should generate prepare hooks and finish hooks into the Makefile. Can you try whether the issue is solved by that version? Artifacts are available in the workflow runs for the branch.

scymtym avatar Oct 02 '25 01:10 scymtym

@LeroyR Did you have time to try the branch?

scymtym avatar Oct 14 '25 13:10 scymtym

Yes. Hook works but the fist command is to cd into output which makes the file not relocatable and breaks on relative output directories e.g.

> ./build-generator generate-makefile -o=./makefiles --set toolkit.volume=/tmp/volumes citk/distributions/tiago-jammy-one-sim-minimal.distribution
> cd makefiles && make
Executing tiago-jammy-one-sim-minimal-prepare-hook_unix
/bin/bash: line 4: cd: ./makefiles/: No such file or directory
make: *** [Makefile:15: tiago-jammy-one-sim-minimal-prepare-hook_unix] Error 1

The other jobs dont cd so it should be either removed for the hook or added to all jobs (and resolve relative paths :D)

LeroyR avatar Oct 14 '25 17:10 LeroyR

I removed the directory change from the generated prepare and finish hooks.

scymtym avatar Oct 16 '25 20:10 scymtym