sparqlwrapper icon indicating copy to clipboard operation
sparqlwrapper copied to clipboard

Not all tests pass

Open aucampia opened this issue 4 years ago • 6 comments

Currently there are a couple of failing tests, for details see: https://github.com/RDFLib/sparqlwrapper/runs/4747557845?check_suite_focus=true

aucampia avatar Jan 09 '22 09:01 aucampia

I created PR. it makes some tests passed.

https://github.com/aucampia/sparqlwrapper/pull/1

eggplants avatar Jan 09 '22 11:01 eggplants

Rather make pr against main repo, there is nothing in here that is not already in master and I'm not actively working on this.

aucampia avatar Jan 09 '22 16:01 aucampia

Note: SPARQL endpoints of virtuoso and 4store server refuse POST request. (Depends on the server configuration?)

eggplants avatar Jan 10 '22 22:01 eggplants

For cases decorated by expectedFailure, I think we need to change it to skip later. And in the future, I'd like to generate pytest classes from configuration files (e.g. yaml or ini) for each server.

eggplants avatar Jan 12 '22 18:01 eggplants

For cases decorated by expectedFailure, I think we need to change it to skip later. And in the future, I'd like to generate pytest classes from configuration files (e.g. yaml or ini) for each server.

If we don't expect the test to pass for a specific endpoint then yes, skip makes more sense, but then in that case we should not even really have a test, and if we take the approach of having an endpoint spec in yaml which specifies the feautres of an endpoint then it probably makes most sense to just not generate them, but I can also see how skip would make sense then, so I'm open to both options.

Thank you for all your effort and appologies that we don't direct more efforts towards this repo.,

aucampia avatar Jan 12 '22 18:01 aucampia

OK.

Thank you for your reviewing and supporting too. I think this library is quite useful and should be maintained.

eggplants avatar Jan 12 '22 19:01 eggplants