prez icon indicating copy to clipboard operation
prez copied to clipboard

Improve builtin labels

Open lalewis1 opened this issue 10 months ago • 5 comments

  • [x] Replace rdf in prez/reference_data/context_ontologies with the annotations from the sematic background repo.
  • [x] rename context_ontologies to annotations.
  • [x] make sure that prez still loads them into the annotations repo

lalewis1 avatar Apr 04 '24 02:04 lalewis1

In doing the above, I have discoverd that there are issues in the semantic background annotations. namely that there are multiple definitions for the same things. for example a label for dcterms:creator is given in both dcterms and pav.

prez returns all the labels and in this case a poor label is chosen. I'm sure other instances of this exist, so I need to go back to the semantic background and clean them up so that only definitions for terms from the current vocab are captured in the annotations, so as to not clash with the authority of the source ontology.

lalewis1 avatar Apr 05 '24 02:04 lalewis1

duplication of labels issue is now resolved in branch lawson/labels

However, I noticed now that a lot of the tests are failing because (the hard coded) expected responses for some requests (like in test_dd_profiles) are expecting the descriptions / labels that were given in the old context_ontologies/*.nq files.

probably not worth trying to resolve (as I based my branch off main.) might have to go back and create a new branch off one of the newer branches and put in the effort to patch the tests their.

@recalcitrantsupplant would your rdframe integration branch be the best base branch for this?

lalewis1 avatar Apr 08 '24 05:04 lalewis1

Yes it will be

recalcitrantsupplant avatar Apr 09 '24 22:04 recalcitrantsupplant

Thanks,

implemented and all tests passing but not tested with prez-ui. just waiting for Jamie to help me get prez-ui set up locally so I can test that and then I will submit a PR.

lalewis1 avatar Apr 09 '24 23:04 lalewis1

Tested with prez ui v4 and all semback labels are displaying nicely.

lalewis1 avatar Apr 10 '24 01:04 lalewis1

@lalewis1 can this be closed now?

recalcitrantsupplant avatar Jun 03 '24 23:06 recalcitrantsupplant

yep.

lalewis1 avatar Jun 04 '24 02:06 lalewis1