Ruth Cheesley comments

Results 889 comments of


                                            Ruth Cheesley

Locale can't be analysed as a campaign condition

Thanks for flagging this and for linking it up to the other issue @dsp76 :)

Filter report data by tags

@patrykgruszka wondered if you had any thoughts on my feedback?

Show contact lists for Forms, Pages, and Assets

Bumping to 3.2 due to unresolved conflicts

Show contact lists for Forms, Pages, and Assets

@cla-bot check

Show contact lists for Forms, Pages, and Assets

Sorry .... naughty cat activity! 😊 😼

Show contact lists for Forms, Pages, and Assets

@maxlawton testing this on Mautibox and it works perfectly! Great new feature! Unfortunately we are going to need to [increase the test coverage](https://github.com/mautic/mautic/pull/6203#issuecomment-724230116) before we are able to merge, can...

Show contact lists for Forms, Pages, and Assets

I can't myself but will ask one of the core team if they can give some pointers!

Show contact lists for Forms, Pages, and Assets

@maxlawton sorry, something in this PR seems to be causing those tests to fail. It may not be relating to the tests you wrote, but some change in this PR...

Show contact lists for Forms, Pages, and Assets

Yeah it looks like there are the same three tests failing: https://github.com/mautic/mautic/pull/6203/checks?check_run_id=3079119984#step:9:111 ``` 1) Mautic\LeadBundle\Tests\Controller\AjaxControllerFunctionalTest::testToggleLeadCampaignAction Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ -Array &0...

TPROD-290 The Kernel::getRootDir() and the kernel.root_dir parameter have been removed

@rohitp19 can you take a look at the feedback and also address the conflict / failing test? Thanks!