Ruth Cheesley
Ruth Cheesley
@all-contributors add @bergwerkweb for code @bergwerkweb please can you check the failing tests, they will need to be resolved before we can merge the PR. Thanks!
Thanks @bergwerkweb - I think this is one of the sometimes flakey tests which can occasionally time out on GitHub Actions. I've just merged in the latest from the 5.x...
Thanks for fixing the code style issue, it looks like we need to improve the test coverage before we can merge this. Are you comfortable with working on automated tests...
@escopecz would you be able to suggest how we can address the code coverage?
@bergwerkweb are you able to write a test based on the example provided to cover the changes you've made in this PR?
@bergwerkweb would you maybe be available on Friday (17th Feb) for our open source friday sprint so we can help get this over the line? Would be awesome to get...
@bergwerkweb we would love to merge this - do you think that you can get to the feedback and writing the unit test now? We are very short of resources...
@PatrickJenkner did you happen to check the logs to see what the error message was?
Just tested this myself, the error is: `[2023-08-11 16:17:58] mautic.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "Key "errors" does not exist as the array is empty." at /var/www/html/app/bundles/LeadBundle/Resources/views/Lead/lead.html.twig line 465 {"exception":"[object] (Twig\\Error\\RuntimeError(code:...
It's already reported in https://github.com/mautic/mautic/issues/12082 so this PR is good to go otherwise IMO, subject to test coverage and addressing the feedback.