Ruth Cheesley
Ruth Cheesley
We make bug fix releases from the minor branch - see the branching strategy: https://contribute.mautic.org/contributing-to-mautic/developer/code/pull-requests#choose-the-right-branch. The original PR was based on 4.x but if this PR contains those changes we...
@JakubHelis features will only be merged to 5.x going forward so that PR will have to be rebased. I will reach out to Marcel as there is also outstanding feedback...
I have a query - I was able to reproduce the issue where only the contacts with a value set are added into the segment. When I applied this PR,...
@cla-bot check
@alfredoct96 thanks for making this PR, sounds like a great feature! I have changed the base to 'features' as this is what we are using now for new features. I...
@alfredoct96 I have had a bit of a struggle trying to rebase your PR - it seems that there is an issue with the branch, but also it is a...
@alfredoct96 it looks like there are a few files where we [need to improve test coverage](https://github.com/mautic/mautic/pull/9493#issuecomment-744508582) before we are able to merge this. Are you able to take a look...
@mabumusa1 @adiux @swadeshp if we could get your tests on this PR I am hopeful we'll get it into 4.2 at the end of May - please take a look...
Thanks for the PR @diaboloshogunate - Codecov is suggesting that the test coverage needs to be improved but I think this _could_ maybe be due to the fact that some...
@alfredoct96 can you take a look at the feedback regarding media/js/app.js needing to be removed? Thanks!