JS-OS icon indicating copy to clipboard operation
JS-OS copied to clipboard

Published 20 hours ago • verified publisher icon RAJAGOPALAN-GANGADHARAN

Migrate react classes to use the latest hooks

Open RAJAGOPALAN-GANGADHARAN opened this issue 4 years ago • 6 comments

Either migrating one class at a time(All the essential window wrappers and then the pre installed applications) or Migrating it all at once, Whichever method works fine.

RAJAGOPALAN-GANGADHARAN avatar Feb 06 '21 12:02 RAJAGOPALAN-GANGADHARAN

Hi, I would like to work on this issue. Could you please assign it to me?

abhinav5481 avatar Feb 19 '21 07:02 abhinav5481

Hey @abhinav5481 , Good luck. Ping me if you need any help.

RAJAGOPALAN-GANGADHARAN avatar Feb 19 '21 09:02 RAJAGOPALAN-GANGADHARAN

I would like to work on this. Just one doubt: Do I need to change every file with class components to hooks or some specific files only?

shmiitg avatar Dec 10 '21 06:12 shmiitg

Hello @shmiitg , Thank you for your interest in this - we have to migrate every class from classes to hooks but we could do it one by one. Starting from non impacted defaultapps like say minesweeper etc

RAJAGOPALAN-GANGADHARAN avatar Dec 11 '21 05:12 RAJAGOPALAN-GANGADHARAN

Ok sir, I got it. I will start working on this. You can assign me this issue.

shmiitg avatar Dec 11 '21 07:12 shmiitg

Sir i have changed the following files: calender.js codestudio.js menubar.js minesweeper markdown_editor.js markdown_reader.js pdf.js processmanager.js

I am sending a pr, if you dont find any mistakes you can merge it, I will slowly and gradually change all the files.

shmiitg avatar Dec 11 '21 20:12 shmiitg