radar-prmt-android icon indicating copy to clipboard operation
radar-prmt-android copied to clipboard

Published 20 hours ago • verified publisher icon RADAR-base

Added icon for google sleep plugin

Open this-Aditya opened this issue 1 year ago • 8 comments

Updated the icon or google sleep plugin.

this-Aditya avatar Jul 18 '23 14:07 this-Aditya

Screenshot_20230718-193634

this-Aditya avatar Jul 18 '23 14:07 this-Aditya

Sure, thanks! I will update the Provider class soon.

this-Aditya avatar Aug 21 '23 12:08 this-Aditya

Is this superseded by #135 ?

yatharthranjan avatar May 09 '24 14:05 yatharthranjan

Hi, it doesn't. The supporting PR for #135 -> https://github.com/RADAR-base/radar-commons-android/pull/437https://github.com/RADAR-base/radar-commons-android/pull/437 was closed because it was not working for every plugin.

this-Aditya avatar May 09 '24 15:05 this-Aditya

Ok in that case, do we need to add more cases here for the other google plugins?

yatharthranjan avatar May 09 '24 15:05 yatharthranjan

As Joris suggested, it would be nice if generalized via radar-commons-android, and then each plugin can update its icon itself. Is it okay if I try to make it work in another PR again?

this-Aditya avatar May 09 '24 15:05 this-Aditya

ok, that would be great, thanks.

yatharthranjan avatar May 09 '24 18:05 yatharthranjan

Added new PR here -> #141.

this-Aditya avatar May 13 '24 15:05 this-Aditya