ManagementPortal icon indicating copy to clipboard operation
ManagementPortal copied to clipboard

Added public endpoint for fetching subset of projects info

Open this-Aditya opened this issue 1 year ago • 4 comments

Added a new endpoint for fetching the project data to be used for the self-enrollment portal

Fixes https://github.com/RADAR-base/ManagementPortal/issues/915

this-Aditya avatar Aug 05 '24 06:08 this-Aditya

Nice work @this-Aditya,

Some thoughts, feel free to override:

  • We already have a class MinimumprojectDetails, is that perhaps suitable to expand here?
  • We might benefit from naming these public endpoints something like api/projects/public and putting it in the ProjectResource.
  • Alternatively, I would switch to projects-lite so that any alphabetically ordered endpoint listing will group this with api/projects

I guess I just logically group this with Project a little more than is done in the current implementation. If others disagree (@yatharthranjan @mpgxvii) feel free to approve and move forward

Bdegraaf1234 avatar Aug 05 '24 09:08 Bdegraaf1234

Thanks for the review, @Bdegraaf1234 ! I’ll make the desired modifications. Additionally, would it be acceptable to also retrieve the updated MinimalProjectDetails when fetching from the api/projects endpoint with the minimized parameter set to true?

this-Aditya avatar Aug 05 '24 09:08 this-Aditya

Yeah that might be an issue, I think it would be good to check with if someone knows where we use the minimized endpoint..

Are you in the SEP meeting later today? Would be good to discuss this there

Bdegraaf1234 avatar Aug 05 '24 09:08 Bdegraaf1234

Okay, fine. I don't have an invite for that meeting. Could you please share the link on Slack? Thanks.

this-Aditya avatar Aug 05 '24 09:08 this-Aditya

Merging for now. We can create separate PRs if changes are needed

yatharthranjan avatar Aug 13 '24 15:08 yatharthranjan