RA80533
RA80533
The actual type test fails. It seems the test was written expecting it to evaluate at run-time but it actually evaluates the test at compile-time. ```typescript // %inferred-type: any res;...
The error we're actually seeing is a result of the expectation failing due to the type mismatch. It's not very clear on its own but, when we inspect the function...
When I did this PR originally, I removed line 31 in order to get the tests to pass because of the failed expectation.
https://github.com/moltar/typescript-runtime-type-benchmarks/blob/73b6b8fc66c961f3a8bdc4655fe3a30782caaf1f/cases/abstract.ts#L6 Annotating `data` as type `Data` rather than `any` allows the expectation to pass.
Jest already runs the TypeScript compiler through ts-jest so the extra workflow step of calling `tsc --noEmit` via `test:build` is redundant.
> Not redundant, because not all code is tested. As evident from your original issue - the benchmarking code was failing after an automatic upgrade. After a bit of digging,...
> Based on #524 I'd probably be somewhat against it - looks like extra noise & fluff from my perspective. Are there particular changes in the PR that you would...
@betawaffle, is there anything we can do to help? Is there anyone from the @cue-sh organization willing to assist with the initial steps of publishing the extension?
Do any of you personally use Express without prototype sanitization? What areas of your services would suffer as a result of Express handling prototype sanitization?