NorthstarMods icon indicating copy to clipboard operation
NorthstarMods copied to clipboard

[Progression] Implement Match Goals menu and XP tracking

Open Zanieon opened this issue 2 years ago • 2 comments

Currently Match Goals menu is unused and will never update properly regardless if player is earning XP through matches, for the post summary screen all of that will count as Double XP due to improper leveling tracking of where each XP point is going into, so this PR should fully implements and integrates _challenges.gnut script, solving this problem.

  • [x] Implement Weapon Leveling tracking
  • [x] Implement Titan Leveling tracking
  • [x] Implement Match Score for all vanilla gamemodes
  • [x] Implement Match Complete bonus
  • [x] Implement Match Won bonus
  • [x] Implement Successful Evac bonus
  • [x] Implement Squad Leader bonus
  • [x] Implement proper Double XP tracking
  • [x] Implement Faction Leveling tracking (invisible in esc menu, but counts in post-summary)
  • [x] Properly Rewards Advocate Gifts for leveling anything

Clipboard01

Zanieon avatar Oct 22 '23 22:10 Zanieon

All of vanilla gamemodes have proper hooks for their Merit Score Challenges now, shall i expand that into custom ones located in Northstar.Custom?

Zanieon avatar Nov 05 '23 20:11 Zanieon

Not able to test the code at the moment, but having a better/working xP + merit system would greatly improve the Vanilla experience and give players who want to have Progression enabled more options to permanently unlock weapons, titans, and skins.

AshesToAshes76 avatar Jan 30 '24 03:01 AshesToAshes76

Can we please get this merged, i have other stuff to PR which i considers the implementation of this PR on them.

Zanieon avatar Jun 27 '24 21:06 Zanieon

I'm assuming you tested this a bunch on your FD servers? ^^

GeckoEidechse avatar Jun 27 '24 22:06 GeckoEidechse

I integrated this already in my FD branch, so all FD servers being hosted right now shows this PR working.

EDIT: Integrated it MONTHS ago.

Zanieon avatar Jun 27 '24 23:06 Zanieon

Tested on a local listen server Appears to do what it says on the tin image

I initially tried testing it with attrition but FlightCore installs PRs without installing a navmesh so I had to manually spawn them in

Jan200101 avatar Jun 28 '24 18:06 Jan200101

unsure if any more feedback is needed @GeckoEidechse

Jan200101 avatar Jun 28 '24 18:06 Jan200101

Thanks so much for the review and the ping <3

GeckoEidechse avatar Jun 28 '24 18:06 GeckoEidechse

Merging based on reviews o7

GeckoEidechse avatar Jun 28 '24 18:06 GeckoEidechse