NorthstarMods
NorthstarMods copied to clipboard
Tag Search Functionality
DO NOT MERGE THIS PR WITHOUT THE OTHER TWO PRS AS IT WILL BREAK STUFF
Linked PRs:
- R2Northstar/NorthstarMasterServer/pull/27 (Storing, Acessing)
- R2Northstar/NorthstarLauncher/pull/67 (Uploading)
Changes:
- Adds extra field to config
- Adds tag search and tag dsplay per server
whys there a max of 5 tags
whys there a max of 5 tags
prob to prevent servers having too many tags
whys there a max of 5 tags
As Fifty said, to prevent tag spam
In my opinion the best northstar tag system would work through three separate systems:
- Automatic tags requiring no host output: Gameservers would report to masterserver their modified match settings so clients could run filters based on that. Ex: client filters for
no_epilogue
tag which would only show servers that haverun_epilogue
set to 0,low_gravity
maps to servers with gravity lower than default, etc. - Country tags would use a separate field like how https://github.com/R2Northstar/Northstar/issues/41 suggests.
- Arbitrary string tags could re-use the server description field (or even title) instead of adding a new one, currently the serverbrowser doesn't filter for descriptions but it should be faily easy to implement
My problem with accepting this PR in its current state is that:
- It's tedious to add tags reflecting your in-game settings and hosts probably will forget to do it or won't even use it at all.
- Having tags as arbitrary strings is too open and might fail to group servers like the host intends. Ex: someone using
brazil
vsbrasil
,EU
vsEurope
With this implementation tags become limited and defined by game settings or geographic regions which helps to create a proper filtering UI for the frontend.
If this were the case, how would you decide which "things" are worthy of generating a tag for? How little gravity is low gravity? How slow is slow movement? no_epilogue
seems pretty pointless of a tag to me, seeing as epilogue is dependent on gamemode (as far as I'm aware).
I don't mind country tags. It will probably remove some ambiguity/mispellings and ensure that a server location and by extension a way to estimate ping is present on every server.
I agree with the fact that tags are too open, but I don't think the right solution is to search by description. You will then instead end up with huge descriptions reading "tags: x,y,z," as has happened with so many other platforms.