NorthstarMasterServer icon indicating copy to clipboard operation
NorthstarMasterServer copied to clipboard

restructured a bunch of stuff

Open barnabwhy opened this issue 2 years ago • 3 comments

didn't get around to making any real changes before exams began and cba to anymore but i made a few fixes

actual additions:

  • announcements endpoint, for apex-style announcements to be displayed on launch
    • could be implemented pretty easy in client by adding a menu that renders over the top once loaded into the lobby and storing an archive cvar of the timestamp of last time it fetched announcements to filter out ones that have already been seen
  • stop reuse of game tokens by comparing to previously used ones (hashes them with bcrypt so that it's actually like, securely stored and shit)

the little changes i spoke of:

  • remove unnecessary deps (xml2js in origin.js, you could just tell origin to give json response)
  • reorganised some stuff so it makes more sense where it is
  • add some missing error codes
  • dep updates: fastify multipart
  • qol stuff: consistent formatting in require, rename accounts to db (to make expansion seem more logical), etc
  • renamed playerdata.db to northstar.db (automatically performs rename)
  • pretty-print fastify logs

barnabwhy avatar Jun 13 '22 21:06 barnabwhy

This is way too much for a single PR IMO. Probably best to split it up until smaller ones if possible ^^

GeckoEidechse avatar Jun 13 '22 21:06 GeckoEidechse

This is way too much for a single PR IMO. Probably best to split it up until smaller ones if possible ^^

me no care, ooga booga. mid-exam pr go brrr

barnabwhy avatar Jun 13 '22 21:06 barnabwhy

This is way too much for a single PR IMO. Probably best to split it up until smaller ones if possible ^^

me no care, ooga booga. mid-exam pr go brrr

Putting this as draft then to prevent someone merging on accident

GeckoEidechse avatar Jun 13 '22 23:06 GeckoEidechse

Superseded by R2Northstar/Atlas.

pg9182 avatar Oct 22 '22 04:10 pg9182