NorthstarLauncher
NorthstarLauncher copied to clipboard
R2Northstar
use tabs for only indentation, not alignment
So applying clang-format locally right now with this PR and not sure if stuff like this is intended...
Like shouldn't last indentation still be tab in this case?
EDIT: Version with clang-format applied: https://github.com/R2Northstar/NorthstarLauncher/tree/indentation-test
Like shouldn't last indentation still be tab in this case?
That would probably depend on our settings for indenting stuff like that?
Like shouldn't last indentation still be tab in this case?
Looked into it and no, this is considered alignment because it is handled by AlignAfterOpenBracket which we have set to AlwaysBreak
Personally, I think setting it to Align makes more sense. This results in:
whilst also not causing (other values of UseTab)
I think the current change is good enough to warrant a merge atm, it's definitely better than before
@GeckoEidechse thoughts?
Uh, I'll have to give it another. Haven't gotten around still. Too much to do. In general tabs should only be used for indentation cause that's how tab indentation works.
Just wanna double check how much stuff goes weird with the change.
Ok so looking at this again, I found in testing that vscode for example does not support this type of mixed indentation.
Not gonna lie, I'm starting to just get frustrated with tab based indentation. Like the whole point about tabs is that you can adjust indentation level to your liking, yet at the same time, you still need spaces for alignment. Mixing tabs and spaces for alignment breaks this idea cause elements get misaligned. But using spaces for alignment and tabs for indentation is not properly supported by IDEs cause they would have to understand the underlying language to be able to to tell whether the action we perform is alignment or indentation.
So merging this will result in people using tabs for alignment cause that's what their IDE inserts and then having CI formatting check fail with no obvious indication cause whitespace changes are invisible by definition...
Honestly, can we just switch everything to spaces and be done with this bs? Like as long as we have tabs, we will either have misaligned alignment for anything but tab size 4 or constant formatting issues in new PRs. There's no way around it.
vscode for example does not support this type of mixed indentation
Why would you use vscode for launcher stuff wtf
But using spaces for alignment and tabs for indentation is not properly supported by IDEs cause they would have to understand the underlying language to be able to to tell whether the action we perform is alignment or indentation.
Except any good IDE will just apply clang format automatically when it detects a clang format file
Honestly, can we just switch everything to spaces and be done with this bs? Like as long as we have tabs, we will either have misaligned alignment for anything but tab size 4 or constant formatting issues in new PRs. There's no way around it.
No, accessibility is important. The way around it is to not use shit IDEs that dont use clang format
vscode for example does not support this type of mixed indentation
Why would you use vscode for launcher stuff wtf
Cause I'm on Linux and last time I checked visual studio was not supported on Linux :P
But using spaces for alignment and tabs for indentation is not properly supported by IDEs cause they would have to understand the underlying language to be able to to tell whether the action we perform is alignment or indentation.
Except any good IDE will just apply clang format automatically when it detects a clang format file
Visual Studio exhibits the exact same behaviour as vscode btw. Keep in mind that both pickup clang-format and can select to apply for formatting but when doing normal editing, both fail to switch from "indentation mode" to "alignment mode" during normal editing.
So for example in this screenshot, assuming the right line is our cursor
hitting the TAB key in both IDEs will enter a TAB character even though we are in alignment mode right now and it should've converted the entered tab to 4 spaces.
Honestly, can we just switch everything to spaces and be done with this bs? Like as long as we have tabs, we will either have misaligned alignment for anything but tab size 4 or constant formatting issues in new PRs. There's no way around it.
No, accessibility is important. The way around it is to not use shit IDEs that dont use clang format
How is tabs vs spaces and accessibility thing? Is it in regards to smaller screen sizes?
hitting the TAB key in both IDEs will enter a TAB character even though we are in alignment mode right now and it should've converted the entered tab to 4 spaces.
Iirc clang format isnt applied after each keystroke, because that would be absurd. I have mine set to format a line when i finish the line, as well as on file save. I forget what the default is
Cause I'm on Linux and last time I checked visual studio was not supported on Linux :P
There are other IDEs. Vscode isnt an IDE, its a text editor that people give some IDE features through extensions
How is tabs vs spaces and accessibility thing? Is it in regards to smaller screen sizes?
Can be. I've seen people who have problems determining indentation differences on lower widths as well, so they run 6-8 width
Honestly the real solution here is to make clang format apply on file save. Not sure if you can define that in like .editorconfig or something
hitting the TAB key in both IDEs will enter a TAB character even though we are in alignment mode right now and it should've converted the entered tab to 4 spaces.
Iirc clang format isnt applied after each keystroke, because that would be absurd.
Obviously.
My complaint is that IDEs (editors, whatever) don't properly switch between tabs and spaces when pressing the TAB key when switching between indentation and alignment.
In an all-spaces codebase, the editor properly converts a TAB press to spaces.
In a codebase that uses tabs for indentation, the editor converts a TAB press to tabs. So when you want to do alignment, you either have to manually press space bar a bunch of times or resort to auto-formatter (which based on the amount of PRs we have with format errors, not everyone does :P)
Perhaps we could just not have format check, but instead just make github actions commit a formatted version or something
@GeckoEidechse Can you update that branch you have and take a look? Hopefully it should be better now