NorthstarLauncher icon indicating copy to clipboard operation
NorthstarLauncher copied to clipboard

Crash removing `runtime/compiled` folder

Open ASpoonPlaysGames opened this issue 1 year ago • 4 comments

Crash log from user in Discord:

nslog2023-09-12_21-48-53.txt

Seems to be caused by this code? https://github.com/R2Northstar/NorthstarLauncher/blob/07e76e3a8e2738dbb7a1d5a6aeaa908a838f5a02/NorthstarDLL/mods/modmanager.cpp#L589

Solution to the problem was to delete the folder manually, although this is a temporary fix I would assume.

ASpoonPlaysGames avatar Sep 12 '23 20:09 ASpoonPlaysGames

"remove_all: Zugriff verweigert: "R2Northstar\runtime\compiled"

The launcher doesn't have the necessary permissions to delete the folder for some reason

uniboi avatar Sep 12 '23 20:09 uniboi

The launcher doesn't have the necessary permissions to delete the folder for some reason

That seems to be the case, yeah. We definitely shouldn't crash like this though, should probably display an error dialog or something explaining the issue? (Or we could try and handle the exception nicely but I doubt that that is possible given the error)

ASpoonPlaysGames avatar Sep 12 '23 20:09 ASpoonPlaysGames

Yeah a windows message box would probably be enough. How does this even happen though

uniboi avatar Sep 12 '23 20:09 uniboi

I honestly have no idea. Perhaps just a read-only folder thing for some reason? perhaps they installed the game into a read-only folder and then marked most of it as not read-only, but missed this folder somehow? idk

ASpoonPlaysGames avatar Sep 12 '23 20:09 ASpoonPlaysGames