NorthstarLauncher
NorthstarLauncher copied to clipboard
R2Northstar
Remove `ns_startup_args*.txt` functionality
Why
- We need to hook
GetCommandLineAto support these.txtfiles, but before doing so we already read the commandline meaning some args dont work in the .txt. - Current way of
strstringGetCommandLineAcan lead to false positives with arguments that start with the same prefix.
What
tier0.dll exports CommandLine() with which we can check the command line. We already have this mapped out and use in some cases so this is just improving code consistency.
How
- Do some sort of warning before removing functionality Print warning, discord announcement ?
- Add support in mod-managers Add support to directly passing arguments to the process when creating it
- Remove functionality in a minor verison increase Patch versions mainly serve for small fixes and small features, this is a pretty big change in behavior
- Possibly have some sort of warning that checks if the file exists after this is implemented
The only problem I have with this, is it's now more difficult to have a mod manager be able to change the launch options. As, unless it's launching the .exe's directly, it wont really be able to change the launch options very easily. Say if you're launching through Steam.
Unless I'm mistaken, and there's some easy way to do this?
Unless I'm mistaken, and there's some easy way to do this?
See how FlightCore does it
See how FlightCore does it
According to this, FlightCore simply doesn't support changing launch arguments. Unless thats outdated?
According to this, FlightCore simply doesn't support changing launch arguments. Unless thats outdated?
https://github.com/R2NorthstarTools/FlightCore/blob/5714309211d389c453c19bb77755855de33655fd/src-tauri/src/northstar/mod.rs#L260
Ah, I stand corrected, I wasn't aware you could add launch arguments to steam://run URIs
Actually maybe we should do this together with a few other breaking changes that are coming up like with MAD (#757) and a potential mod folder restructure via #746