Use of templated function within header without available implementation

Open Jan200101 opened this issue 2 years ago • 1 comments

squirrel.h makes use of NS::log::squirrel_logger https://github.com/R2Northstar/NorthstarLauncher/blob/23594f24d3a2b09f5d8f912a773540ff3c1db841/NorthstarDLL/squirrel/squirrel.h#L351

but this method is only implemented in squirrel.cpp https://github.com/R2Northstar/NorthstarLauncher/blob/23594f24d3a2b09f5d8f912a773540ff3c1db841/NorthstarDLL/squirrel/squirrel.cpp#L33-L41

Thus the header cannot reasonable make use of the method since it lacks an implementation for the type it references.

The solution would be to move the function into the header, but I have had problems with it refusing to accept the extern NS::log::SCRIPT_* usage.

Jun 26 '23 09:06 Jan200101

The calls to squirrel_logger in the header were added in #355, so I guess @emma-miler is the one I should ask about this

Jun 26 '23 11:06 Jan200101