NorthstarLauncher icon indicating copy to clipboard operation
NorthstarLauncher copied to clipboard

Allow Postload to be used with modded rpaks properly

Open ASpoonPlaysGames opened this issue 2 years ago • 1 comments

Closes #229 This allows Postload to use relative paths for the target rpak, meaning modded rpaks can be used as valid Postload targets.

This is now valid, and will cause the following rpak load order: common.rpak -> betapulse_preload.rpak -> betapulse.rpak "Postload": { "betapulse_preload.rpak": "common.rpak", "betapulse.rpak": "./betapulse_preload.rpak" }

Importantly, common.rpak is still a valid Postload target, making this not a breaking change for rpak mods

"betapulse.rpak": "betapulse_preload.rpak" would also work in this example, however it would load the rpak if another mod loaded an rpak called betapulse_preload.rpak which could cause problems.

ASpoonPlaysGames avatar Jul 31 '22 00:07 ASpoonPlaysGames

Testing: (ignore example.rpak, thats just another rpak mod i had enabled when i took the screenshot)

unknown unknown

ASpoonPlaysGames avatar Jul 31 '22 00:07 ASpoonPlaysGames

Is this still an issue? If yes, could you describe a way to reproduce it with current build + verify that this PR fixes it?

Alystrasz avatar Apr 17 '23 07:04 Alystrasz

Is this still an issue? If yes, could you describe a way to reproduce it with current build + verify that this PR fixes it?

Kinda? I don't think anyone actually runs into it in practice, but being unable to load an rpak specifically after another modded rpak is annoying in theory.

For testing, see the above comments, nothing about that stuff has changed

ASpoonPlaysGames avatar Aug 25 '23 16:08 ASpoonPlaysGames