Fire the hashchange event even if the navigation changes only `location.hash`
What is it?
- Bug fix
Description
I am making an app with Qwik that is using SPA navigation between pages including URL fragment.
Currently, the SPA navigation doesn't fire the hashchange event if the change of URL is only the hash fragment because it is using history.pushState.
This is not the standard behaviour of the browser.
So I have changed this
- only if the change is consist of the fragment of URL.
- then navigate by using
location.hash = ...due to fire the hashchange event.
Checklist
- [x] My code follows the developer guidelines of this project
- [x] I performed a self-review of my own code
- [ ] I added a changeset with
pnpm change - [ ] I made corresponding changes to the Qwik docs
- [ ] I added new tests to cover the fix / functionality
⚠️ No Changeset found
Latest commit: c9054a895eb5168126bc290d811ef2e3a5e28afc
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
npm i https://pkg.pr.new/@builder.io/qwik@7329
npm i https://pkg.pr.new/@builder.io/qwik-city@7329
npm i https://pkg.pr.new/eslint-plugin-qwik@7329
npm i https://pkg.pr.new/create-qwik@7329
commit: e2dd128
built with Refined Cloudflare Pages Action
⚡ Cloudflare Pages Deployment
| Name | Status | Preview | Last Commit |
|---|---|---|---|
| qwik-docs | ✅ Ready (View Log) | Visit Preview | c9054a895eb5168126bc290d811ef2e3a5e28afc |
it would be great if you add a test for it
@genki Could you add a test for it ?
@JerryWu1234 Sorry currently I can't take a time for a while 🥲