qwik icon indicating copy to clipboard operation
qwik copied to clipboard

initial code to add the search functionnality onto the a small viewport

Open Kampouse opened this issue 1 year ago • 3 comments

What is it?

  • [x] Feature / enhancement
  • [ ] Bug
  • [ ] Docs / tests / types / typos
  • [ ] Infra

Description

I was able to achieve decent behavior by utilizing the QwikUI modal component. The current implementation resulted in the component being partially hidden (off-screen) above pictue. Additionally, the implementation is missing a proper search button icon I'm sharing this here to gather feedback on my progress so far. image

Related issue: #6949

Please feel free to review and provide any suggestions or improvements.

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have ran pnpm change and documented my changes
  • [ ] I have made corresponding changes to the Qwik docs
  • [ ] Added new tests to cover the fix / functionality

Kampouse avatar Oct 11 '24 00:10 Kampouse

⚠️ No Changeset found

Latest commit: 88cd4068949bedeeae9270c92d5d2921fcc1406f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 11 '24 00:10 changeset-bot[bot]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 88cd4068949bedeeae9270c92d5d2921fcc1406f

github-actions[bot] avatar Oct 11 '24 00:10 github-actions[bot]

Added the icon back and made it possible to control the Modal from An external controller The Current search button that is internal to the Component. The normal behaviour to closing and opening work fine the internal controller had some extra wiring that unsure what is for but the base behaviour work

Kampouse avatar Oct 12 '24 00:10 Kampouse

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6966
npm i https://pkg.pr.new/@builder.io/qwik-city@6966
npm i https://pkg.pr.new/eslint-plugin-qwik@6966
npm i https://pkg.pr.new/create-qwik@6966

commit: 88cd406

pkg-pr-new[bot] avatar Mar 15 '25 20:03 pkg-pr-new[bot]

@Kampouse you added 250 commits from somewhere and now your PR has 440 changed files 😬

If you have a Mac I recommend using https://gitup.co to fix this, otherwise see if you can cherry pick your own commits on a fresh branch?

wmertens avatar Mar 16 '25 07:03 wmertens

Alright this is much better did not know about cherry-pick thank you!

Kampouse avatar Mar 16 '25 19:03 Kampouse