qwik icon indicating copy to clipboard operation
qwik copied to clipboard

fix(eslint): Fixed lint problem about the `JSXNode`

Open genki opened this issue 1 year ago • 2 comments

Overview

I have fixed the lint issue about the serialization of th JSXNode (reported #5940) Here is the reproduction of the issue. This code crashes. https://stackblitz.com/edit/qwik-starter-ptzf8r?file=src%2Froutes%2Findex.tsx

What is it?

  • [ ] Feature / enhancement
  • [x] Bug
  • [ ] Docs / tests / types / typos

Description

It was needed to check the symbol name if it is the JSXNode before checking of the callable things in order to avoid to be checked the internal structures of JSXNode and being kicked out.

Use cases and why

Relating #5940

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [x] Added new tests to cover the fix / functionality

genki avatar Jul 03 '24 01:07 genki

Deploy request for qwik-insights rejected.

Name Link
Latest commit 3b37a5a29329c9fa45ea6b9701d7fd1f3fb84b6d

netlify[bot] avatar Jul 03 '24 01:07 netlify[bot]

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 1516e28

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6637
@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6637
eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6637
create-qwik

npm i https://pkg.pr.new/create-qwik@6637

templates

pkg-pr-new[bot] avatar Jul 03 '24 02:07 pkg-pr-new[bot]

can you run pnpm api.update so it doesn't have the api changes? Those get added by the build somewhere and we don't know why.

wmertens avatar Jul 09 '24 15:07 wmertens

@wmertens I have misunderstood about the order of execution of tasks api.update and build.full that was api.update then build.full. But the right way was inverse. Now I did it.

genki avatar Jul 09 '24 17:07 genki