qwik icon indicating copy to clipboard operation
qwik copied to clipboard

test(optimizer/core): import attributes

Open PatrickJS opened this issue 1 year ago • 6 comments

add import attribute to rust

PatrickJS avatar May 11 '24 23:05 PatrickJS

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0ca5d12
Status: ✅  Deploy successful!
Preview URL: https://638376b2.qwik-8nx.pages.dev
Branch Preview URL: https://test-rust-import-attributes.qwik-8nx.pages.dev

View logs

You need to run pnpm test.rust.update

wmertens avatar May 13 '24 04:05 wmertens

ok just did but it looks like it fails when it should work (since import attributes changes to with keyword)

PatrickJS avatar May 13 '24 16:05 PatrickJS

waiting on this pr i think https://github.com/QwikDev/qwik/pull/6005

PatrickJS avatar May 13 '24 21:05 PatrickJS

This is now handled via #6005. Not sure if we need a test for it, the entire functionality is provided by SWC

wmertens avatar Aug 01 '24 10:08 wmertens

@PatrickJS do you want to rebase and pnpm test.rust.update? Should just work and then we can be sure we don't regress

wmertens avatar Oct 06 '24 18:10 wmertens