qwik icon indicating copy to clipboard operation
qwik copied to clipboard

docs: Fix README badges

Open rerelurelu opened this issue 1 year ago • 3 comments

Overview

スクリーンショット 2024-03-16 17 29 17

  • Remove Vercel Server badge
  • Add Vercel Serverless badge
  • Add Vercel Edge budge

What is it?

  • [ ] Feature / enhancement
  • [ ] Bug
  • [x] Docs / tests / types / typos

Description

As mentioned Overview.

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [x] Added new tests to cover the fix / functionality

rerelurelu avatar Mar 16 '24 08:03 rerelurelu

Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
Latest commit 0bf7fdb152b01c7a56f45305fc4f04ad4d6ee0d7

netlify[bot] avatar Mar 16 '24 08:03 netlify[bot]

I tested this change but it's showing "failing" :thinking:

image

gioboa avatar Mar 18 '24 14:03 gioboa

I tested this change but it's showing "failing"

It's showing up because the Vercel Edge and Vercel Serverless workflows are failing. Neither of these errors is caused by this PR.

rerelurelu avatar Mar 19 '24 03:03 rerelurelu

Thanks! I don't suppose you can fix the workflows? ;-)

wmertens avatar Mar 22 '24 06:03 wmertens

So the serverless workflow fails here https://github.com/BuilderIO/qwik-city-e2e/actions/runs/8362101976/job/22891855652#step:8:26

and the edge workflow was disabled 8 months ago :thinking:

wmertens avatar Mar 22 '24 06:03 wmertens

ok the qwik-city branch of the workflows is behind, that's why. Added a PR https://github.com/BuilderIO/qwik-city-e2e/pull/10

wmertens avatar Mar 22 '24 06:03 wmertens