chore: Remove undici, set minimum node version to 18.17
sharp requires "^18.17.0 || ^20.3.0 || >=21.0.0", and that's the cause of installation issues.
Furthermore, global fetch is in node since v18, so we don't need undici any more.
Bun and Deno also include fetch.
Deploy request for qwik-insights pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 1d9fa8802c665a408db64cddf82880c8a7e70da7 |
⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | Google API Key | 1d9fa8802c665a408db64cddf82880c8a7e70da7 | packages/docs/scripts/showcase.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@wmertens
When will this change be merged?
@manucorporat the macro plugin keeps erroring on insights/src/root.tsx, even though it hasn't changed. It says the code is unreachable. Any idea what could cause this? This single commit PR must be the reason because I keep rebasing on main which has no error.
can we change the min version to node 20? 😁 20 is a lot faster
is this PR still valid or is it abandoned ?
is this PR still valid or is it abandoned ?
If I am not mistaken they are waiting for version 2.0.
⚠️ No Changeset found
Latest commit: b3b2530bb79daf58c7c1a6dfa7bac8d4ae0a4714
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR