qwik icon indicating copy to clipboard operation
qwik copied to clipboard

docs: added package manager tabs

Open saisrikardumpeti opened this issue 1 year ago • 12 comments

Overview

#5174

What is it?

  • [x] Feature / enhancement
  • [ ] Bug
  • [x] Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • [ ] My code follows the developer guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

saisrikardumpeti avatar Dec 29 '23 17:12 saisrikardumpeti

Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
Latest commit c1c93435be244a21616529ef62764550b0edf660

netlify[bot] avatar Dec 29 '23 17:12 netlify[bot]

should i add @qwik-ui/headless to vite optimization dependencies. @gioboa

saisrikardumpeti avatar Dec 29 '23 17:12 saisrikardumpeti

No, the latest @qwik-ui/headless solves the big bundle size issue.

gioboa avatar Dec 29 '23 18:12 gioboa

some CI tests failed how can i make it right?

saisrikardumpeti avatar Dec 29 '23 18:12 saisrikardumpeti

I pushed a small change. Thanks for your commitment @the-r3aper7

gioboa avatar Dec 29 '23 19:12 gioboa

I pushed a small change. Thanks for your commitment @the-r3aper7

thank you, i like that icon change.

saisrikardumpeti avatar Dec 29 '23 19:12 saisrikardumpeti

@gioboa i have make changes regarding to get the cookie but i am not able to think of getting setCookie correct as we need to pass Cookie object to setCookie and should i change the setCookie function in shop/utils WDYT?

saisrikardumpeti avatar Jan 02 '24 08:01 saisrikardumpeti

@gioboa i have tried basic document.cookie in setCookie it does not work with the shop as it is not able to set cartId in cookies. can you give some ideas?

saisrikardumpeti avatar Jan 09 '24 16:01 saisrikardumpeti

@the-r3aper7 So you're having trouble with the setCookie function? Can you explain more, and rebase?

wmertens avatar Jan 17 '24 14:01 wmertens

@the-r3aper7 So you're having trouble with the setCookie function? Can you explain more, and rebase?

yeah i was not able to set the Cookie using setCookie as it requires Cookie object which is can be obtained from RequestEventLoader and i am able to process that on client and i am currently using document.cookie to set cookie.

after that i tried to change the setCookie with document.cookie which was not successful :disappointed:

saisrikardumpeti avatar Jan 17 '24 17:01 saisrikardumpeti

I'm confused about your setCookie function that takes 3 arguments, the third called options, but you're passing a string

wmertens avatar Jan 17 '24 17:01 wmertens

I'm confused about your setCookie function that takes 3 arguments, the third called options, but you're passing a string

i am directly adding cookie to the browser. am i misinterpreting something?

saisrikardumpeti avatar Jan 17 '24 17:01 saisrikardumpeti

Closed by #6636 6636

gioboa avatar Jul 02 '24 22:07 gioboa