qwik icon indicating copy to clipboard operation
qwik copied to clipboard

Type of RouteLocation['params'] incorrect

Open blakeley opened this issue 2 years ago • 1 comments

https://github.com/BuilderIO/qwik/blob/374f25e7c2759651cffa652f2bd16241e53c9c24/packages/qwik-city/runtime/src/types.ts#L65

When navigating with a <Link>, params used on the page can temporarily be undefined. Navigation should either not render the current page with the next route's param values, or the type of params should be changed to be

    readonly params: Readonly<Record<string, string | undefined>>;

blakeley avatar Oct 22 '23 13:10 blakeley

Good point, would you be willing to send a PR?

mhevery avatar Oct 23 '23 15:10 mhevery

In v2 we are solving this issue by improving and implementing the navigation in a better way.

gioboa avatar Aug 26 '25 19:08 gioboa

should be solved by #7816

Varixo avatar Aug 27 '25 14:08 Varixo