qwik
qwik copied to clipboard
QWIKOSS-2 - [✨] When closing over values in `server$` the values should be marked as readonly
What does this PR do?
This PR ensures that values serialized by server$() are immutable and triggers a clear error message if any mutation is attempted
Issue reference
https://github.com/BuilderIO/qwik/issues/5019
Demo video/scrennshot:
https://www.loom.com/share/abc8b587001d4845bc55748000b0412f?sid=945d461e-79cc-4cd3-a80f-0e99bb0aa065 Happy hacking! 🎉
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.
Deploy request for qwik-insights pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 637900249d281adeb8ae9f22b9a161ccf4cb1a34 |
Love this change. Let me know when it is ready.
Hi @gitstart thanks for your help, are you still on this PR or is it abandoned?
Hi @gitstart thanks for your help, are you still on this PR or is it abandoned?
Sorry for the delay. we are still working on the issue
@gitstart could you rebase?
@gitstart still interested in finishing this?
@wmertens @mhevery I'm changing this to only freeze in dev
in the future technically we can pass the current client value to the server then update the client signals from the server response