qwik icon indicating copy to clipboard operation
qwik copied to clipboard

fix(core): looping over deeply changed object should update

Open mhevery opened this issue 2 years ago • 3 comments

Fix #5017

Overview

What is it?

  • [ ] Feature / enhancement
  • [ ] Bug
  • [ ] Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • [ ] My code follows the developer guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

mhevery avatar Aug 28 '23 23:08 mhevery

Deploy Preview for qwik-insights failed.

Name Link
Latest commit 245651dfeea261a007881eb091017c840cae676c
Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6562f2113549a6000924b521

netlify[bot] avatar Aug 28 '23 23:08 netlify[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 245651d
Status: ✅  Deploy successful!
Preview URL: https://2e7252bf.qwik-docs.pages.dev
Branch Preview URL: https://issue-5017.qwik-docs.pages.dev

View logs

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Sep 01 '23 22:09 gitguardian[bot]

looks like it's going to be fixed in v2

PatrickJS avatar May 10 '24 20:05 PatrickJS