qwik icon indicating copy to clipboard operation
qwik copied to clipboard
verified publisher icon QwikDev

build: make root.tsx optional

Open shairez opened this issue 2 years ago • 5 comments

What is it?

  • [x] Feature / enhancement
  • [ ] Bug
  • [ ] Docs / tests

Description

Make build root.tsx for client mode building to make it easier for testing tools to run Qwik libraries.

shairez avatar Mar 26 '23 13:03 shairez

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bolt-new-by-stackblitz[bot] avatar Mar 26 '23 13:03 bolt-new-by-stackblitz[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 678d503
Status: ✅  Deploy successful!
Preview URL: https://b4342f56.qwik-docs.pages.dev
Branch Preview URL: https://pr-root-tsx.qwik-docs.pages.dev

View logs

cloudflare-workers-and-pages[bot] avatar Mar 26 '23 13:03 cloudflare-workers-and-pages[bot]

@shairez can you better explain the motivation?

mhevery avatar Jun 30 '23 16:06 mhevery

Yes, it's something me and @manucorporat figured out when trying to build the cypress plugin.

I ran into some limitations when trying to fix this, but I need to complete this work when I'll have time

shairez avatar Jun 30 '23 23:06 shairez

oh I actually ran into this when I was working on Qwik Start. It should be optional

PatrickJS avatar Feb 25 '24 01:02 PatrickJS

can we redo this PR

PatrickJS avatar May 01 '24 01:05 PatrickJS

we're going to do this as part of the vite environment support

wmertens avatar Oct 06 '24 18:10 wmertens