qwik icon indicating copy to clipboard operation
qwik copied to clipboard

docs: updated example

Open the-r3aper7 opened this issue 2 years ago • 6 comments

What is it?

  • [ ] Feature / enhancement
  • [ ] Bug
  • [x] Docs / tests

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

the-r3aper7 avatar Dec 04 '22 06:12 the-r3aper7

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Dec 04 '22 06:12 stackblitz[bot]

why are you changing the links? absolute is easier to maintain and refactor (moving things around does not break links)

manucorporat avatar Dec 04 '22 11:12 manucorporat

I think you have tell me the reason before has it is changed since then?

the-r3aper7 avatar Dec 04 '22 11:12 the-r3aper7

The previous PR had links not pointing to any index.mdx file, but the path directly

manucorporat avatar Dec 04 '22 16:12 manucorporat

okay i will revert those changes now

the-r3aper7 avatar Dec 04 '22 16:12 the-r3aper7

Hi @the-r3aper7 Looks like this PR is not mergable atm due to some conflicts. Would you mind to fix them?

zanettin avatar Jan 15 '23 19:01 zanettin

thanks a lot @the-r3aper7 🙏 @shairez @n8sabes imo ready to get merged 🎉

zanettin avatar Jan 19 '23 10:01 zanettin

Thanks for the ping @zanettin !

And thanks for this PR @the-r3aper7 🙏

shairez avatar Jan 19 '23 21:01 shairez