qwik icon indicating copy to clipboard operation
qwik copied to clipboard

docs: added useOn hooks

Open the-r3aper7 opened this issue 2 years ago • 10 comments

What is it?

  • [ ] Feature / enhancement
  • [ ] Bug
  • [x] Docs / tests

Description

This should solve #2282

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

the-r3aper7 avatar Nov 28 '22 17:11 the-r3aper7

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Nov 28 '22 17:11 stackblitz[bot]

thanks @the-r3aper7 !

I think this should be part of the "Lifecycle" page no?

Maybe we should rename it in the menu to "Lifecycle (hooks)" to make it clearer

shairez avatar Nov 29 '22 23:11 shairez

cool I will make the changes by tonight just let me know if we should have a different page for this named Lifecycle (hooks) or add these things in Lifecycle page?

the-r3aper7 avatar Nov 30 '22 04:11 the-r3aper7

thanks buddy!

shairez avatar Nov 30 '22 11:11 shairez

on second thought - not sure it's related to lifecycle it looks like utils for adding event listeners in general

@manucorporat WDYT?

shairez avatar Dec 01 '22 11:12 shairez

wondering if this is events

manucorporat avatar Dec 07 '22 14:12 manucorporat

for me this are just events, in fact it's the same as doing: <div onClick, but programatically, so it can be composed with hooks

manucorporat avatar Dec 07 '22 14:12 manucorporat

so, where should we add this?

the-r3aper7 avatar Dec 07 '22 15:12 the-r3aper7

@shairez @manucorporat i have made the changes see it's matches the context of events page.

the-r3aper7 avatar Dec 10 '22 17:12 the-r3aper7

@manucorporat @shairez just tested the changes locally and they LGTM 👍 thanks a lot @the-r3aper7 🙏 hope we get this merged soon since it is a great addition for the docs imo.

zanettin avatar Jan 12 '23 21:01 zanettin

thanks @the-r3aper7 and @zanettin ! merging

shairez avatar Jan 16 '23 00:01 shairez