qwik icon indicating copy to clipboard operation
qwik copied to clipboard

feat: inlined fn

Open manucorporat opened this issue 3 years ago • 2 comments

Allow qwik runtime and optimizer to inline functions, this functions can still capture lexical scope and used to prevent downloads to whole template during rerendering.

manucorporat avatar Nov 12 '22 14:11 manucorporat

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

So you have to manually mark them with $$? Will there be some heuristic that automatically does this for $ functions as well?

wmertens avatar Nov 15 '22 07:11 wmertens

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 00ea585
Status: ✅  Deploy successful!
Preview URL: https://c8571a21.qwik-docs.pages.dev
Branch Preview URL: https://inlined-fn.qwik-docs.pages.dev

View logs

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
314151 Google API Key 62fa87c003894aa9701f9e3b15aabefb83bb98fa packages/docs/scripts/showcase.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Mar 05 '23 19:03 gitguardian[bot]

Looks like this might fix https://github.com/BuilderIO/qwik/issues/3081 🥳

DustinJSilk avatar Mar 07 '23 17:03 DustinJSilk