qwik icon indicating copy to clipboard operation
qwik copied to clipboard

Aria/rel fix

Open timscodebase opened this issue 1 year ago • 3 comments

What is it?

  • [X ] Feature / enhancement
  • [ X] Bug
  • [ ] Docs / tests

Description

The header was missing standard aria and rel tags

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • [ ] My code follows the developer guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

timscodebase avatar Oct 25 '22 04:10 timscodebase

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Oct 25 '22 04:10 stackblitz[bot]

I think the linter is complainign because we are using single quotes, instead of double. Should be fixed by running:

yarn fmt

manucorporat avatar Oct 26 '22 23:10 manucorporat

@timscodebase can you please run yarn fmt or prettier --fix for the specific file?

Thanks!

shairez avatar Oct 31 '22 00:10 shairez

Hi @timscodebase 👋 Thanks a lot for your input 🙏 do you have a chance to implement the mentioned changes against the current state? Otherwise leave a quick note, so anybody else can have a look at it 🙏

zanettin avatar Feb 17 '23 13:02 zanettin

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Google API Key de6e60845d427e44cef7291f9073593cb59cb1eb packages/docs/scripts/showcase.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Mar 04 '23 21:03 gitguardian[bot]