qwik icon indicating copy to clipboard operation
qwik copied to clipboard

Published 20 hours ago • verified publisher icon QwikDev

fix: default ctrl + k search event.

Open the-r3aper7 opened this issue 2 years ago • 4 comments

What is it?

  • [ ] Feature / enhancement
  • [x] Bug
  • [ ] Docs / tests

Description

on CTRL + K it should prevent default browser event and open the search box.

Use cases and why

Actual Behavior: actual

Expected Behavior: expected

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

the-r3aper7 avatar Oct 23 '22 19:10 the-r3aper7

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Oct 23 '22 19:10 stackblitz[bot]

Only thing that bugging me is that it will load JavaScript of useClientEffect on initial load.

the-r3aper7 avatar Oct 23 '22 19:10 the-r3aper7

What would Qwik need to have to implement this without client effect?

manucorporat avatar Oct 24 '22 09:10 manucorporat

I used the preventdefault:keydown and onKeyDown$ in div, it was preventing every keydown event except for CTRL + K in current window.

the-r3aper7 avatar Oct 24 '22 09:10 the-r3aper7

Hi @the-r3aper7 👋 I am scanning some open PRs atm and it looks like this issue was already resolved in the meantime. Can you confirm that? Thanks again for your time to create this PR 🙏

zanettin avatar Feb 25 '23 20:02 zanettin