qwik
qwik copied to clipboard
feat(sass support): added support for .sass and .scss files
What is it?
- [X] Feature / enhancement
- [ ] Bug
- [ ] Docs / tests
Description
Qwik already supports css files and css modules. Vite out of the box supports sass and scss files along with their module counterparts. This change enables the usage of SASS files and SASS modules.
Use cases and why
-
-
.scss
and.sass
files even though correctly processed by Vite, are never properly exposed. Even though class names are properly created bycss-modules
through*.module.scss
files, the actual stylesheets are unavailable to the components. This change let Qwik properly utilise styles transpiled by Vite.
-
Checklist:
- [x] My code follows the developer guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation
- [ ] Added new tests to cover the fix / functionality
Run & review this pull request in StackBlitz Codeflow.
I also need suggestion for the tests.
Lint fails, might need to run yarn fmt