qwik icon indicating copy to clipboard operation
qwik copied to clipboard

feat(sass support): added support for .sass and .scss files

Open IgorSzymanski opened this issue 2 years ago • 3 comments

What is it?

  • [X] Feature / enhancement
  • [ ] Bug
  • [ ] Docs / tests

Description

Qwik already supports css files and css modules. Vite out of the box supports sass and scss files along with their module counterparts. This change enables the usage of SASS files and SASS modules.

Use cases and why

    1. .scss and .sass files even though correctly processed by Vite, are never properly exposed. Even though class names are properly created by css-modules through *.module.scss files, the actual stylesheets are unavailable to the components. This change let Qwik properly utilise styles transpiled by Vite.

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

IgorSzymanski avatar Oct 18 '22 16:10 IgorSzymanski

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Oct 18 '22 16:10 stackblitz[bot]

I also need suggestion for the tests.

IgorSzymanski avatar Oct 18 '22 16:10 IgorSzymanski

Lint fails, might need to run yarn fmt

manucorporat avatar Oct 19 '22 18:10 manucorporat